From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Mon, 25 Apr 2016 23:04:05 +0000 (-0600)
Subject: Shared memory corruption when storing multi-slot (>32KB) shm misses.
X-Git-Tag: SQUID_4_0_10~11
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=82a190b9f3bc169bbda2c2e607b2c4c1c36d9226;p=thirdparty%2Fsquid.git

Shared memory corruption when storing multi-slot (>32KB) shm misses.

This is a regression I introduced in trunk r14584 (Bug 7: Update
cached entries on 304 responses).
---

diff --git a/src/MemStore.cc b/src/MemStore.cc
index 259fbec675..c8db5ca52f 100644
--- a/src/MemStore.cc
+++ b/src/MemStore.cc
@@ -777,6 +777,7 @@ MemStore::nextAppendableSlice(const sfileno fileNo, sfileno &sliceOffset)
             slice.next = sliceOffset = reserveSapForWriting(page);
             extras->items[sliceOffset].page = page;
             debugs(20, 7, "entry " << fileNo << " new slice: " << sliceOffset);
+            continue; // to get and return the slice at the new sliceOffset
         }
 
         return slice;