From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Wed, 7 Sep 2016 19:00:14 +0000 (+0300)
Subject: imap: Fixed assert-crash if un-hibernation failed to initialize user.
X-Git-Tag: 2.3.0.rc1~3073
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=82b3d02b7384847d077b9121e08b9838903fd3d7;p=thirdparty%2Fdovecot%2Fcore.git

imap: Fixed assert-crash if un-hibernation failed to initialize user.

master_service_client_connection_destroyed() was also being called in
imap_master_client_destroy() so it was done twice.

Fixes:
Panic: file master-service.c: line 775 (master_service_client_connection_destroyed): assertion failed: (service->total_available_count > 0)
---

diff --git a/src/imap/imap-master-client.c b/src/imap/imap-master-client.c
index e24c0a94ac..8e5732558c 100644
--- a/src/imap/imap-master-client.c
+++ b/src/imap/imap-master-client.c
@@ -215,7 +215,6 @@ imap_master_client_input_args(struct connection *conn, const char *const *args,
 	if (ret < 0) {
 		i_error("imap-master(%s): Failed to create client: %s",
 			input.username, error);
-		master_service_client_connection_destroyed(master_service);
 		i_close_fd(&fd_client);
 		return -1;
 	}