From: Shachar Sharon Date: Wed, 17 Sep 2025 11:25:27 +0000 (+0300) Subject: vfs_ceph_new: dont use ceph_ll_nonblocking_readv_writev for fsync_send X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=82c0988a8bc3d3e364e2d56ad8ea27e359fbc3f0;p=thirdparty%2Fsamba.git vfs_ceph_new: dont use ceph_ll_nonblocking_readv_writev for fsync_send Commit 4ae922413844 ("vfs_ceph_new: use libcephfs nonblocking API for async-io ops") uses ceph_ll_nonblocking_readv_writev for fsync_send. However, the actual behaviour of libcephfs when using this API with 'fsync=true' is not async-fsync, as one may assume. Instead, vfs_ceph_new should use a nonblocking fsync API[1], once it is ready. Removed the usage of ceph_ll_nonblocking_readv_writev for fsync. Bug: https://bugzilla.samba.org/show_bug.cgi?id=15919 [1] https://github.com/ceph/ceph/commit/c88a21c30d8b265adb152f631d2629d29539f7b7 Signed-off-by: Shachar Sharon Reviewed-by: Anoop C S Reviewed-by: Xavi Hernandez Reviewed-by: Guenther Deschner --- diff --git a/source3/modules/vfs_ceph_new.c b/source3/modules/vfs_ceph_new.c index 7112719a399..c2435be9804 100644 --- a/source3/modules/vfs_ceph_new.c +++ b/source3/modules/vfs_ceph_new.c @@ -3018,16 +3018,6 @@ static struct tevent_req *vfs_ceph_fsync_send(struct vfs_handle_struct *handle, SMBPROFILE_BYTES_ASYNC_SET_IDLE_X(state->profile_bytes, state->profile_bytes_x); -#if HAVE_CEPH_ASYNCIO - state->req = req; - state->data = NULL; - state->len = 0; - state->off = 0; - state->fsync = true; - vfs_ceph_aio_submit(handle, req, ev); - return req; -#endif - vfs_ceph_aio_start(state); ret = vfs_ceph_ll_fsync(handle, state->cfh, false); vfs_ceph_aio_finish(state, ret);