From: Amos Jeffries <yadij@users.noreply.github.com>
Date: Wed, 29 May 2024 06:05:08 +0000 (+0000)
Subject: MinGW: Fix error: cannot convert 'const int*' to 'const char*' (#1824)
X-Git-Tag: SQUID_7_0_1~115
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=82c51da13d3ed70d6f200857930a01c825c549c7;p=thirdparty%2Fsquid.git

MinGW: Fix error: cannot convert 'const int*' to 'const char*' (#1824)
---

diff --git a/src/comm/Tcp.cc b/src/comm/Tcp.cc
index 43c5da0d9e..c847cfbc60 100644
--- a/src/comm/Tcp.cc
+++ b/src/comm/Tcp.cc
@@ -30,7 +30,7 @@ SetSocketOption(const int fd, const int level, const int optName, const Option &
 {
     static_assert(std::is_trivially_copyable<Option>::value, "setsockopt() expects POD-like options");
     static_assert(!std::is_same<Option, bool>::value, "setsockopt() uses int to represent boolean options");
-    if (setsockopt(fd, level, optName, &optValue, sizeof(optValue)) < 0) {
+    if (setsockopt(fd, level, optName, reinterpret_cast<const char *>(&optValue), sizeof(optValue)) < 0) {
         const auto xerrno = errno;
         debugs(5, DBG_IMPORTANT, "ERROR: setsockopt(2) failure: " << xstrerr(xerrno));
         // TODO: Generalize to throw on errors when some callers need that.