From: Volker Lendecke <vl@samba.org>
Date: Tue, 29 Oct 2024 08:01:43 +0000 (+0100)
Subject: libnet4: Call map_netlogon_samlogon_response directly
X-Git-Tag: tdb-1.4.13~607
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=82d8f345f5785d7ede11f2fc3278ee59396f37db;p=thirdparty%2Fsamba.git

libnet4: Call map_netlogon_samlogon_response directly

Avoid using a boolean flag passed down

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source4/libnet/libnet_become_dc.c b/source4/libnet/libnet_become_dc.c
index f7da0cc777d..c429b96bdfc 100644
--- a/source4/libnet/libnet_become_dc.c
+++ b/source4/libnet/libnet_become_dc.c
@@ -763,7 +763,6 @@ static void becomeDC_send_cldap(struct libnet_BecomeDC_state *s)
 	s->cldap.io.in.domain_sid	= NULL;
 	s->cldap.io.in.acct_control	= -1;
 	s->cldap.io.in.version		= NETLOGON_NT_VERSION_5 | NETLOGON_NT_VERSION_5EX;
-	s->cldap.io.in.map_response	= true;
 
 	ret = tsocket_address_inet_from_strings(s, "ip",
 						s->source_dsa.address,
@@ -800,6 +799,8 @@ static void becomeDC_recv_cldap(struct tevent_req *req)
 			 nt_errstr(c->status)));
 		return;
 	}
+
+	map_netlogon_samlogon_response(&s->cldap.io.out.netlogon);
 	s->cldap.netlogon = s->cldap.io.out.netlogon.data.nt5_ex;
 
 	s->domain.dns_name		= s->cldap.netlogon.dns_domain;