From: Amos Jeffries <squid3@treenet.co.nz>
Date: Fri, 11 Jul 2008 01:34:36 +0000 (+1200)
Subject: Author: Christos Tsantilas <chtsanti@users.sourceforge.net>
X-Git-Tag: SQUID_3_1_0_1~49^2~155
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=83181157a4818afe836fbac126aedfa8e7385629;p=thirdparty%2Fsquid.git

Author: Christos Tsantilas <chtsanti@users.sourceforge.net>
Bug 2400: ICAP accept mechanism assumes okay result

ACL checks produces an ACCESS_REQ_PROXY_AUTH result but ICAP
result handler assumes any non-zero result means ACCESS_ALLOWED

This can result in many requests being shunted to ICAP incorrently.
---

diff --git a/src/adaptation/AccessCheck.cc b/src/adaptation/AccessCheck.cc
index 4e6b2ff883..870f610e77 100644
--- a/src/adaptation/AccessCheck.cc
+++ b/src/adaptation/AccessCheck.cc
@@ -123,7 +123,7 @@ Adaptation::AccessCheck::AccessCheckCallbackWrapper(int answer, void *data)
 {
     debugs(93, 8, "AccessCheckCallbackWrapper: answer=" << answer);
     AccessCheck *ac = (AccessCheck*)data;
-    ac->noteAnswer(answer);
+    ac->noteAnswer(answer==ACCESS_ALLOWED);
 }
 
 void