From: Heiko Hund <heiko.hund@sophos.com>
Date: Thu, 18 Aug 2011 10:16:21 +0000 (+0000)
Subject: remove function is_proto_tcp()
X-Git-Tag: v2.3-alpha1~201
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=834eba7597e2582c44f69e03a762b838308c8df0;p=thirdparty%2Fopenvpn.git

remove function is_proto_tcp()

The implementation of is_proto_tcp() was invalid since the IPv6 stuff got
merged into master. There's proto_is_tcp() that does the same job right.

Remove is_proto_tcp() and make its only caller use proto_is_tcp() instead.

Signed-off-by: Heiko Hund <heiko.hund@sophos.com>
Acked-By: Gert Doering <gert@greenie.muc.de>
Signed-off-by: David Sommerseth <davids@redhat.com>
---

diff --git a/options.c b/options.c
index 7da1180f7..5333cfa95 100644
--- a/options.c
+++ b/options.c
@@ -2417,7 +2417,7 @@ options_postprocess_mutate_ce (struct options *o, struct connection_entry *ce)
     ce->local_port = 0;
 
   /* if protocol forcing is enabled, disable all protocols except for the forced one */
-  if (o->proto_force >= 0 && is_proto_tcp(o->proto_force) != is_proto_tcp(ce->proto))
+  if (o->proto_force >= 0 && proto_is_tcp(o->proto_force) != proto_is_tcp(ce->proto))
     ce->flags |= CE_DISABLED;
 }
 
diff --git a/socket.h b/socket.h
index 33da53c37..6336f9220 100644
--- a/socket.h
+++ b/socket.h
@@ -563,12 +563,6 @@ legal_ipv4_port (int port)
   return port > 0 && port < 65536;
 }
 
-static inline int
-is_proto_tcp(const int p)
-{
-  return p > 0; /* depends on the definition of PROTO_x */
-}
-
 static inline bool
 link_socket_proto_connection_oriented (int proto)
 {