From: Jason Merrill <jason@redhat.com>
Date: Tue, 14 Jul 2009 18:16:03 +0000 (-0400)
Subject: re PR c++/37276 (Trouble with some (C99?) math builtins and namespace std)
X-Git-Tag: releases/gcc-4.5.0~4587
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8353dd9a26485ad8cdc603d98efd8e711f7d2154;p=thirdparty%2Fgcc.git

re PR c++/37276 (Trouble with some (C99?) math builtins and namespace std)

	PR c++/37276
	* decl.c (decls_match): A non-extern-C declaration doesn't match
	a builtin extern-C declaration.

From-SVN: r149638
---

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index d43341b8f6e9..31970570601c 100644
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,5 +1,9 @@
 2009-07-14  Jason Merrill  <jason@redhat.com>
 
+	PR c++/37276
+	* decl.c (decls_match): A non-extern-C declaration doesn't match
+	a builtin extern-C declaration.
+
 	PR c++/40746
 	* name-lookup.c (qualified_lookup_using_namespace): Don't stop
 	looking in used namespaces just because we found something on
@@ -8,8 +12,6 @@
 	PR c++/40740
 	* semantics.c (perform_koenig_lookup): Handle empty template args.
 
-2009-07-13  Jason Merrill  <jason@redhat.com>
-
 	* call.c (build_over_call): Use can_trust_pointer_alignment.
 
 2009-07-14  Dodji Seketeli  <dodji@redhat.com>
diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c
index d7a0e0d96930..e1b6678ea2d0 100644
--- a/gcc/cp/decl.c
+++ b/gcc/cp/decl.c
@@ -932,6 +932,14 @@ decls_match (tree newdecl, tree olddecl)
 		&& DECL_EXTERN_C_P (olddecl)))
 	return 0;
 
+#ifdef NO_IMPLICIT_EXTERN_C
+      /* A new declaration doesn't match a built-in one unless it
+	 is also extern "C".  */
+      if (DECL_BUILT_IN (olddecl)
+	  && DECL_EXTERN_C_P (olddecl) && !DECL_EXTERN_C_P (newdecl))
+	return 0;
+#endif
+
       if (TREE_CODE (f1) != TREE_CODE (f2))
 	return 0;
 
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 1fa70edf74d9..75cd8c0632de 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,5 +1,11 @@
 2009-07-14  Jason Merrill  <jason@redhat.com>
 
+	PR c++/37276
+	* g++.dg/lookup/builtin5.C: New.
+	* g++.dg/other/error22.C: Add missing extern "C".
+	* g++.dg/warn/Warray-bounds.C: Likewise.
+	* gcc.dg/compat/compat-common.h: Likewise.
+
 	PR c++/40746
 	* g++.dg/lookup/using20.C: New.
 
diff --git a/gcc/testsuite/g++.dg/lookup/builtin5.C b/gcc/testsuite/g++.dg/lookup/builtin5.C
new file mode 100644
index 000000000000..1bd67dce5ac6
--- /dev/null
+++ b/gcc/testsuite/g++.dg/lookup/builtin5.C
@@ -0,0 +1,16 @@
+// PR c++/37276
+
+// { dg-final { scan-assembler "_ZSt5atanhd" } }
+
+namespace std
+{
+  inline double
+  atanh(double __x)
+  { return __builtin_atanh(__x); }
+}
+
+int main()
+{
+  std::atanh(.3);
+  return 0;
+}
diff --git a/gcc/testsuite/g++.dg/other/error22.C b/gcc/testsuite/g++.dg/other/error22.C
index 8b7a9e937147..225dcae8214d 100644
--- a/gcc/testsuite/g++.dg/other/error22.C
+++ b/gcc/testsuite/g++.dg/other/error22.C
@@ -1,7 +1,7 @@
 // PR c++/34394
 // { dg-do compile }
 
-extern double fabs (double);
+extern "C" double fabs (double);
 
 void foo (double x)
 {
diff --git a/gcc/testsuite/g++.dg/warn/Warray-bounds.C b/gcc/testsuite/g++.dg/warn/Warray-bounds.C
index d53af5214860..61c7c5d8e32e 100644
--- a/gcc/testsuite/g++.dg/warn/Warray-bounds.C
+++ b/gcc/testsuite/g++.dg/warn/Warray-bounds.C
@@ -3,8 +3,9 @@
 
 int a[10];
 
+extern "C" __SIZE_TYPE__ strlen(const char *s);
+
 static inline int n(void) {
-    __SIZE_TYPE__ strlen(const char *s);
     return strlen("12345");
 }
 
diff --git a/gcc/testsuite/gcc.dg/compat/compat-common.h b/gcc/testsuite/gcc.dg/compat/compat-common.h
index 40d4e08f9f17..8a92ea3e606a 100644
--- a/gcc/testsuite/gcc.dg/compat/compat-common.h
+++ b/gcc/testsuite/gcc.dg/compat/compat-common.h
@@ -47,5 +47,9 @@
 #endif
 #endif
 
+#ifdef __cplusplus
+extern "C" void abort (void);
+#else
 extern void abort (void);
+#endif
 extern int fails;