From: Tom Tromey <tom@tromey.com>
Date: Sat, 11 Mar 2023 05:16:51 +0000 (-0700)
Subject: Remove a check of VAR_DOMAIN
X-Git-Tag: gdb-15-branchpoint~1113
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8370bcc7b7b966ea86a7c87ba1549e607da7ac25;p=thirdparty%2Fbinutils-gdb.git

Remove a check of VAR_DOMAIN

completion_list_add_symbol checks that the returned symbol has
VAR_DOMAIN, but also checks that its address class is LOC_BLOCK.  The
domain check is redundant -- only functions can possibly be LOC_BLOCK
-- and leaving this in place will cause a regression when combined
with a later patch in this series.  This patch preemptively removes
the redundant check.
---

diff --git a/gdb/symtab.c b/gdb/symtab.c
index 7c56dbadf8c..76a771b1166 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -5631,7 +5631,6 @@ completion_list_add_symbol (completion_tracker &tracker,
      the msymbol name and removes the msymbol name from the completion
      tracker.  */
   if (sym->language () == language_cplus
-      && sym->domain () == VAR_DOMAIN
       && sym->aclass () == LOC_BLOCK)
     {
       /* The call to canonicalize returns the empty string if the input