From: Pablo Neira Ayuso Date: Tue, 25 Apr 2023 10:37:15 +0000 (+0200) Subject: mnl: incomplete extended error reporting for singleton device in chain X-Git-Tag: v1.0.8~53 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8398bd1e9fc722d88b96c9b93b1171c0a5bafa2d;p=thirdparty%2Fnftables.git mnl: incomplete extended error reporting for singleton device in chain Fix error reporting when single device is specifies in chain: # nft add chain netdev filter ingress '{ devices = { x }; }' add chain netdev filter ingress { devices = { x }; } ^ Fixes: a66b5ad9540d ("src: allow for updating devices on existing netdev chain") Signed-off-by: Pablo Neira Ayuso --- diff --git a/src/mnl.c b/src/mnl.c index 5dcfd9a0..adc0bd3d 100644 --- a/src/mnl.c +++ b/src/mnl.c @@ -790,6 +790,7 @@ static void mnl_nft_chain_devs_build(struct nlmsghdr *nlh, struct cmd *cmd) dev_array = nft_dev_array(dev_expr, &num_devs); if (num_devs == 1) { + cmd_add_loc(cmd, nlh->nlmsg_len, dev_array[0].location); mnl_attr_put_strz(nlh, NFTA_HOOK_DEV, dev_array[0].ifname); } else { nest_dev = mnl_attr_nest_start(nlh, NFTA_HOOK_DEVS);