From: Markus Armbruster <armbru@redhat.com>
Date: Thu, 22 Aug 2019 13:38:46 +0000 (+0200)
Subject: pr-manager: Fix invalid g_free() crash bug
X-Git-Tag: v4.0.1~31
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=83f9b84c8bcb24265e25cd7f22e971e81cacebc6;p=thirdparty%2Fqemu.git

pr-manager: Fix invalid g_free() crash bug

pr_manager_worker() passes its @opaque argument to g_free().  Wrong;
it points to pr_manager_worker()'s automatic @data.  Broken when
commit 2f3a7ab39be converted @data from heap- to stack-allocated.  Fix
by deleting the g_free().

Fixes: 2f3a7ab39bec4ba8022dc4d42ea641165b004e3e
Cc: qemu-stable@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit 6b9d62c2a9e83bbad73fb61406f0ff69b46ff6f3)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---

diff --git a/scsi/pr-manager.c b/scsi/pr-manager.c
index d9f4e8c3adb..227bdfaad2d 100644
--- a/scsi/pr-manager.c
+++ b/scsi/pr-manager.c
@@ -38,7 +38,6 @@ static int pr_manager_worker(void *opaque)
     int fd = data->fd;
     int r;
 
-    g_free(data);
     trace_pr_manager_run(fd, hdr->cmdp[0], hdr->cmdp[1]);
 
     /* The reference was taken in pr_manager_execute.  */