From: drh <>
Date: Thu, 2 Dec 2021 12:34:05 +0000 (+0000)
Subject: More small performance optimizations for sqlite3WhereGetMask().
X-Git-Tag: version-3.38.0~207
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=844a89b518c47864e2c0e6d41ea85947c48519ed;p=thirdparty%2Fsqlite.git

More small performance optimizations for sqlite3WhereGetMask().

FossilOrigin-Name: 3de2c557d915d1b4a9b0e540d5e80ffb243e7123d0ec65c5052f4d6f1cce56b2
---

diff --git a/manifest b/manifest
index 650ae769af..1d0d293e6a 100644
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Small\sperformance\soptimization\sin\ssqlite3WhereGetMask().
-D 2021-12-02T04:00:45.798
+C More\ssmall\sperformance\soptimizations\sfor\ssqlite3WhereGetMask().
+D 2021-12-02T12:34:05.331
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
 F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -637,7 +637,7 @@ F src/vxworks.h d2988f4e5a61a4dfe82c6524dd3d6e4f2ce3cdb9
 F src/wal.c ed0398a7adf02c31e34aada42cc86c58f413a7afe5f741a5d373ad087abde028
 F src/wal.h c3aa7825bfa2fe0d85bef2db94655f99870a285778baa36307c0a16da32b226a
 F src/walker.c f890a3298418d7cba3b69b8803594fdc484ea241206a8dfa99db6dd36f8cbb3b
-F src/where.c 90903cab02f03aded5019e45cd1dec6adf307291a6af0e55fce5111e84cc9115
+F src/where.c b50391df607937593596fbb8ea39f673d9a3715a65750567b442d22dd20720ca
 F src/whereInt.h 1630d9418512b080598e9a72b8af6b8bd1b9ab13fee1458f151762b6df206791
 F src/wherecode.c 1f5b62f46d284c8886945eb7438415bc27e23e87bb60b9ee468fa6bd31268f33
 F src/whereexpr.c 17bdbf4f5b490e70a18635498f0b910a558f953a9bf80af7f19cbde6e60e6825
@@ -1933,7 +1933,7 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P ed84e124c6097b756ca687ac64df7ee801d14b16c835f1a9e8b336f785157d85
-R 4968f927e754c905a194070e8df46560
+P 7edec54ab045c0493fc5d27d47d7bf0e08d3b0b298f428646fd3f0ee24dfcade
+R 1c3ef5334121101d82935d790fc38231
 U drh
-Z 0a6600fef45926158d5c9c07197fe75a
+Z 3bbf6be35a1404f46b703105b00b0544
diff --git a/manifest.uuid b/manifest.uuid
index 3e8bb6ca63..d5b9582fdc 100644
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-7edec54ab045c0493fc5d27d47d7bf0e08d3b0b298f428646fd3f0ee24dfcade
\ No newline at end of file
+3de2c557d915d1b4a9b0e540d5e80ffb243e7123d0ec65c5052f4d6f1cce56b2
\ No newline at end of file
diff --git a/src/where.c b/src/where.c
index a661940b39..925f98af16 100644
--- a/src/where.c
+++ b/src/where.c
@@ -232,15 +232,18 @@ whereOrInsert_done:
 ** iCursor is not in the set.
 */
 Bitmask sqlite3WhereGetMask(WhereMaskSet *pMaskSet, int iCursor){
-  int i = 0;
+  int i;
   assert( pMaskSet->n<=(int)sizeof(Bitmask)*8 );
   assert( pMaskSet->n>0 || pMaskSet->ix[0]<0 );
   assert( iCursor>=-1 );
-  do{
+  if( pMaskSet->ix[0]==iCursor ){
+    return 1;
+  }
+  for(i=1; i<pMaskSet->n; i++){
     if( pMaskSet->ix[i]==iCursor ){
       return MASKBIT(i);
     }
-  }while( (++i)<pMaskSet->n );
+  }
   return 0;
 }
 
@@ -4916,6 +4919,10 @@ WhereInfo *sqlite3WhereBegin(
   memset(&pWInfo->a[0], 0, sizeof(WhereLoop)+nTabList*sizeof(WhereLevel));
   assert( pWInfo->eOnePass==ONEPASS_OFF );  /* ONEPASS defaults to OFF */
   pMaskSet = &pWInfo->sMaskSet;
+  pMaskSet->n = 0;
+  pMaskSet->ix[0] = -99; /* Initialize ix[0] to a value that can never be
+                         ** a valid cursor number, to avoid an initial
+                         ** test for pMaskSet->n==0 in sqlite3WhereGetMask() */
   sWLB.pWInfo = pWInfo;
   sWLB.pWC = &pWInfo->sWC;
   sWLB.pNew = (WhereLoop*)(((char*)pWInfo)+nByteWInfo);
@@ -4928,8 +4935,6 @@ WhereInfo *sqlite3WhereBegin(
   /* Split the WHERE clause into separate subexpressions where each
   ** subexpression is separated by an AND operator.
   */
-  pMaskSet->n = 0;
-  pMaskSet->ix[0] = -99;
   sqlite3WhereClauseInit(&pWInfo->sWC, pWInfo);
   sqlite3WhereSplit(&pWInfo->sWC, pWhere, TK_AND);