From: Peter Geoghegan <pg@bowt.ie>
Date: Sun, 1 Mar 2020 20:11:26 +0000 (-0800)
Subject: Remove dead code from _bt_update_posting().
X-Git-Tag: REL_13_BETA1~638
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=84ec9b231a865348f5388dcc125c084297709332;p=thirdparty%2Fpostgresql.git

Remove dead code from _bt_update_posting().

Discussion: https://postgr.es/m/CAH2-WzmAufHiOku6AGiFD=81VQs5nYJ1L2YkhW1t+BH4CMsgRw@mail.gmail.com
---

diff --git a/src/backend/access/nbtree/nbtdedup.c b/src/backend/access/nbtree/nbtdedup.c
index e5481f2f93f..3175d6fdd1d 100644
--- a/src/backend/access/nbtree/nbtdedup.c
+++ b/src/backend/access/nbtree/nbtdedup.c
@@ -674,11 +674,6 @@ _bt_update_posting(BTVacuumPosting vacposting)
 	Assert(_bt_posting_valid(origtuple));
 	Assert(nhtids > 0 && nhtids < BTreeTupleGetNPosting(origtuple));
 
-	if (BTreeTupleIsPosting(origtuple))
-		keysize = BTreeTupleGetPostingOffset(origtuple);
-	else
-		keysize = IndexTupleSize(origtuple);
-
 	/*
 	 * Determine final size of new tuple.
 	 *
@@ -686,6 +681,7 @@ _bt_update_posting(BTVacuumPosting vacposting)
 	 * for new posting list tuples.  We avoid calling _bt_form_posting() here
 	 * to save ourselves a second memory allocation for a htids workspace.
 	 */
+	keysize = BTreeTupleGetPostingOffset(origtuple);
 	if (nhtids > 1)
 		newsize = MAXALIGN(keysize +
 						   nhtids * sizeof(ItemPointerData));