From: Kevin Grittner <kgrittn@postgresql.org>
Date: Wed, 14 Aug 2013 17:43:01 +0000 (-0500)
Subject: Remove Assert that matview is not in system schema from REFRESH.
X-Git-Tag: REL9_3_RC1~21
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=85052376a8cc4bbbfc08a50ca3bd137c1e3cda9a;p=thirdparty%2Fpostgresql.git

Remove Assert that matview is not in system schema from REFRESH.

We don't want to prevent an extension which creates a matview from
being installed in pg_catalog.

Issue was raised by Hitoshi Harada.
Backpatched to 9.3.
---

diff --git a/src/backend/commands/matview.c b/src/backend/commands/matview.c
index 1c383baf687..ce7e427c911 100644
--- a/src/backend/commands/matview.c
+++ b/src/backend/commands/matview.c
@@ -144,11 +144,7 @@ ExecRefreshMatView(RefreshMatViewStmt *stmt, const char *queryString,
 				 errmsg("\"%s\" is not a materialized view",
 						RelationGetRelationName(matviewRel))));
 
-	/*
-	 * We're not using materialized views in the system catalogs.
-	 */
-	Assert(!IsSystemRelation(matviewRel));
-
+	/* We don't allow an oid column for a materialized view. */
 	Assert(!matviewRel->rd_rel->relhasoids);
 
 	/*