From: Ciaran Woodward Date: Mon, 4 Dec 2023 18:49:26 +0000 (+0000) Subject: [gdb/doc] Escape the '@' symbols in generated texinfo files. X-Git-Tag: binutils-2_42~729 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=850f4ee54658152b3f4ce60e2ef1855950c8bcbc;p=thirdparty%2Fbinutils-gdb.git [gdb/doc] Escape the '@' symbols in generated texinfo files. '@' is a special symbol meaning 'command' in GNU texinfo. If the GDBINIT or GDBINIT_DIR path during configuration included an '@' character, the makeinfo command would fail, as it interpreted the '@' in the path as a start of a command when expanding the path in the docs. This patch simply escapes any '@' characters in the path, by replacing them with '@@'. This was already done for the bugurl variable. This was detected because the 'Jenkins' tool sometimes puts an '@' in the workspace path. Approved-By: Tom Tromey --- diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in index 110b6088905..70ee9a8b9cb 100644 --- a/gdb/doc/Makefile.in +++ b/gdb/doc/Makefile.in @@ -429,10 +429,12 @@ GDBvn.texi : version.subst echo "@set SYSTEM_READLINE" >> ./GDBvn.new; \ fi if [ -n "$(SYSTEM_GDBINIT)" ]; then \ - echo "@set SYSTEM_GDBINIT $(SYSTEM_GDBINIT)" >> ./GDBvn.new; \ + escaped_system_gdbinit=`echo $(SYSTEM_GDBINIT) | sed 's/@/@@/g'`; \ + echo "@set SYSTEM_GDBINIT $$escaped_system_gdbinit" >> ./GDBvn.new; \ fi if [ -n "$(SYSTEM_GDBINIT_DIR)" ]; then \ - echo "@set SYSTEM_GDBINIT_DIR $(SYSTEM_GDBINIT_DIR)" >> ./GDBvn.new; \ + escaped_system_gdbinit_dir=`echo $(SYSTEM_GDBINIT_DIR) | sed 's/@/@@/g'`; \ + echo "@set SYSTEM_GDBINIT_DIR $$escaped_system_gdbinit_dir" >> ./GDBvn.new; \ fi mv GDBvn.new GDBvn.texi