From: Willy Tarreau <w@1wt.eu>
Date: Tue, 11 Feb 2014 16:53:37 +0000 (+0100)
Subject: BUG/MAJOR: check: fix memory leak in "tcp-check connect" over SSL
X-Git-Tag: v1.5-dev23~170
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=852745d54844bf08456a5f4e1cae3ac6068f73ea;p=thirdparty%2Fhaproxy.git

BUG/MAJOR: check: fix memory leak in "tcp-check connect" over SSL

tcp-check must not reinitialize the SSL stack upon each check!
It's done once after the config parsing and leaks memory and eats
performance when done upon every check.

This bug was introduced in 1.5-dev22, no backport is needed.
---

diff --git a/src/checks.c b/src/checks.c
index c9a531f32e..1a3e865b87 100644
--- a/src/checks.c
+++ b/src/checks.c
@@ -2091,7 +2091,6 @@ static void tcpcheck_main(struct connection *conn)
 #ifdef USE_OPENSSL
 			if (check->current_step->conn_opts & TCPCHK_OPT_SSL) {
 				xprt = &ssl_sock;
-				ssl_sock_prepare_srv_ctx(s, s->proxy);
 			}
 			else {
 				xprt = &raw_sock;