From: Colin Ian King Date: Wed, 7 May 2025 13:18:34 +0000 (+0100) Subject: RDMA/siw: replace redundant ternary operator with just rv X-Git-Tag: v6.16-rc1~111^2~19 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8536666a52833da326ab17d43ee2cd6c66751716;p=thirdparty%2Flinux.git RDMA/siw: replace redundant ternary operator with just rv The use of the ternary operator on rv is redundant, rv is either the initialized value of 0 or a negative error return code, so it can never be greater than zero, and hence the zero assignment in ternary operator is redundant. Just return rv instead. Signed-off-by: Colin Ian King Link: https://patch.msgid.link/20250507131834.253823-1-colin.i.king@gmail.com Acked-by: Bernard Metzler Signed-off-by: Leon Romanovsky --- diff --git a/drivers/infiniband/sw/siw/siw_verbs.c b/drivers/infiniband/sw/siw/siw_verbs.c index 7ce0035c54fac..2b2a7b8e93b01 100644 --- a/drivers/infiniband/sw/siw/siw_verbs.c +++ b/drivers/infiniband/sw/siw/siw_verbs.c @@ -1102,7 +1102,7 @@ int siw_post_receive(struct ib_qp *base_qp, const struct ib_recv_wr *wr, siw_dbg_qp(qp, "error %d\n", rv); *bad_wr = wr; } - return rv > 0 ? 0 : rv; + return rv; } int siw_destroy_cq(struct ib_cq *base_cq, struct ib_udata *udata)