From: Joe Damato Date: Thu, 14 Nov 2024 17:51:56 +0000 (+0000) Subject: netdev-genl: Hold rcu_read_lock in napi_get X-Git-Tag: v6.11.11~83 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8544602fb6cd5893996d014ce92b73a538a14e4d;p=thirdparty%2Fkernel%2Fstable.git netdev-genl: Hold rcu_read_lock in napi_get commit c53bf100f68619acf6cedcf4cf5249a1ca2db0b4 upstream. Hold rcu_read_lock in netdev_nl_napi_get_doit, which calls napi_by_id and is required to be called under rcu_read_lock. Cc: stable@vger.kernel.org Fixes: 27f91aaf49b3 ("netdev-genl: Add netlink framework functions for napi") Signed-off-by: Joe Damato Link: https://patch.msgid.link/20241114175157.16604-1-jdamato@fastly.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c index a17d7eaeb0019..f8f8c1e50ae4e 100644 --- a/net/core/netdev-genl.c +++ b/net/core/netdev-genl.c @@ -214,6 +214,7 @@ int netdev_nl_napi_get_doit(struct sk_buff *skb, struct genl_info *info) return -ENOMEM; rtnl_lock(); + rcu_read_lock(); napi = napi_by_id(napi_id); if (napi) { @@ -223,6 +224,7 @@ int netdev_nl_napi_get_doit(struct sk_buff *skb, struct genl_info *info) err = -ENOENT; } + rcu_read_unlock(); rtnl_unlock(); if (err)