From: Valentyn <valentin.druzhinin@gmail.com>
Date: Tue, 17 Jun 2025 10:25:20 +0000 (-0400)
Subject: ✅ Simplify tests for `settings` (#13505)
X-Git-Tag: 0.115.13~10
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=85a2eed88836dde7d6c8e275c2abc36f4572e78d;p=thirdparty%2Ffastapi%2Ffastapi.git

✅ Simplify tests for `settings` (#13505)

Co-authored-by: Valentyn Druzhynin <v.druzhynin@zakaz.global>
---

diff --git a/tests/test_tutorial/test_settings/test_tutorial001.py b/tests/test_tutorial/test_settings/test_tutorial001.py
index eb30dbcee4..92a5782d4d 100644
--- a/tests/test_tutorial/test_settings/test_tutorial001.py
+++ b/tests/test_tutorial/test_settings/test_tutorial001.py
@@ -1,14 +1,26 @@
+import importlib
+
+import pytest
 from fastapi.testclient import TestClient
 from pytest import MonkeyPatch
 
-from ...utils import needs_pydanticv2
+from ...utils import needs_pydanticv1, needs_pydanticv2
 
 
-@needs_pydanticv2
-def test_settings(monkeypatch: MonkeyPatch):
+@pytest.fixture(
+    name="app",
+    params=[
+        pytest.param("tutorial001", marks=needs_pydanticv2),
+        pytest.param("tutorial001_pv1", marks=needs_pydanticv1),
+    ],
+)
+def get_app(request: pytest.FixtureRequest, monkeypatch: MonkeyPatch):
     monkeypatch.setenv("ADMIN_EMAIL", "admin@example.com")
-    from docs_src.settings.tutorial001 import app
+    mod = importlib.import_module(f"docs_src.settings.{request.param}")
+    return mod.app
+
 
+def test_settings(app):
     client = TestClient(app)
     response = client.get("/info")
     assert response.status_code == 200, response.text
diff --git a/tests/test_tutorial/test_settings/test_tutorial001_pv1.py b/tests/test_tutorial/test_settings/test_tutorial001_pv1.py
deleted file mode 100644
index e4659de665..0000000000
--- a/tests/test_tutorial/test_settings/test_tutorial001_pv1.py
+++ /dev/null
@@ -1,19 +0,0 @@
-from fastapi.testclient import TestClient
-from pytest import MonkeyPatch
-
-from ...utils import needs_pydanticv1
-
-
-@needs_pydanticv1
-def test_settings(monkeypatch: MonkeyPatch):
-    monkeypatch.setenv("ADMIN_EMAIL", "admin@example.com")
-    from docs_src.settings.tutorial001_pv1 import app
-
-    client = TestClient(app)
-    response = client.get("/info")
-    assert response.status_code == 200, response.text
-    assert response.json() == {
-        "app_name": "Awesome API",
-        "admin_email": "admin@example.com",
-        "items_per_user": 50,
-    }