From: Guido Günther <agx@sigxcpu.org>
Date: Sat, 23 Jul 2011 21:24:21 +0000 (+0200)
Subject: Catch dnsmasq start failures
X-Git-Tag: v0.9.4-rc1~9
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=85a954cebbbb3ae6210a779a5f3b29559ec5f862;p=thirdparty%2Flibvirt.git

Catch dnsmasq start failures

While we checked the return value we didn't maks sure ret != 0 which
resulted in dnsmasq errors being ignored.
---

diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index f242db8c05..a21b538a5d 100644
--- a/src/network/bridge_driver.c
+++ b/src/network/bridge_driver.c
@@ -745,8 +745,10 @@ networkStartDhcpDaemon(virNetworkObjPtr network)
     if (ret < 0)
         goto cleanup;
 
-    if (virCommandRun(cmd, NULL) < 0)
+    ret = virCommandRun(cmd, NULL);
+    if (ret < 0) {
         goto cleanup;
+    }
 
     /*
      * There really is no race here - when dnsmasq daemonizes, its