From: Ján Tomko <jtomko@redhat.com>
Date: Thu, 26 Feb 2015 08:03:09 +0000 (+0100)
Subject: conf: error out on missing dhcp host attributes
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=85ce4d1f7335ed1944070ef3d362a10da6958413;p=thirdparty%2Flibvirt.git

conf: error out on missing dhcp host attributes

In virNetworkDHCPHostDefParseXML an error is reported
when partialOkay == true, and none of ip, mac, name
were supplied.

Add the missing goto and error out in this case.

(cherry picked from commit b15b21f3a52945644c7ccbbe1dd51b86d36ca777)
---

diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index 81e311e446..f3ec1758a2 100644
--- a/src/conf/network_conf.c
+++ b/src/conf/network_conf.c
@@ -737,6 +737,7 @@ virNetworkDHCPHostDefParseXML(const char *networkName,
                              "must be specified for static host definition "
                              "in network '%s' "),
                            networkName);
+            goto cleanup;
         }
     } else {
         /* normal usage - you need at least name (IPv6) or one of MAC