From: Sean Christopherson <seanjc@google.com>
Date: Thu, 10 Oct 2024 18:23:04 +0000 (-0700)
Subject: KVM: Allow calling kvm_release_page_{clean,dirty}() on a NULL page pointer
X-Git-Tag: v6.13-rc1~97^2~17^2~83
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=85e88b2bbaacb4135499fdb219f78ac38ef6e8d4;p=thirdparty%2Fkernel%2Flinux.git

KVM: Allow calling kvm_release_page_{clean,dirty}() on a NULL page pointer

Allow passing a NULL @page to kvm_release_page_{clean,dirty}(), there's no
tangible benefit to forcing the callers to pre-check @page, and it ends up
generating a lot of duplicate boilerplate code.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Sean Christopherson <seanjc@google.com>
Tested-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <20241010182427.1434605-3-seanjc@google.com>
---

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 5fc95504affea..e7561ca96a095 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -3167,7 +3167,7 @@ static void kvm_set_page_accessed(struct page *page)
 
 void kvm_release_page_clean(struct page *page)
 {
-	if (WARN_ON(!page))
+	if (!page)
 		return;
 
 	kvm_set_page_accessed(page);
@@ -3192,7 +3192,7 @@ EXPORT_SYMBOL_GPL(kvm_release_pfn_clean);
 
 void kvm_release_page_dirty(struct page *page)
 {
-	if (WARN_ON(!page))
+	if (!page)
 		return;
 
 	kvm_set_page_dirty(page);