From: two-heart <12869538+two-heart@users.noreply.github.com>
Date: Thu, 4 Sep 2025 10:20:53 +0000 (+0200)
Subject: Only unlock in rsa_get_blinding when locking was successful
X-Git-Tag: openssl-3.6.0-beta1~31
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=860147225e92c6e927984427f61321a163dcd09c;p=thirdparty%2Fopenssl.git

Only unlock in rsa_get_blinding when locking was successful

CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/28438)

(cherry picked from commit dbad8448c2fc659de380204592f31901daebffb8)
---

diff --git a/crypto/rsa/rsa_ossl.c b/crypto/rsa/rsa_ossl.c
index 4165562757c..1e56c6d38c6 100644
--- a/crypto/rsa/rsa_ossl.c
+++ b/crypto/rsa/rsa_ossl.c
@@ -264,8 +264,8 @@ static BN_BLINDING *rsa_get_blinding(RSA *rsa, BN_CTX *ctx)
                 BN_BLINDING_free(ret);
                 ret = NULL;
             }
+            CRYPTO_THREAD_unlock(rsa->lock);
         }
-        CRYPTO_THREAD_unlock(rsa->lock);
     }
 
     return ret;