From: Stephan Bosch Date: Thu, 4 Oct 2018 19:39:58 +0000 (+0200) Subject: submission: commands: Expect connection setup errors from relaying commands. X-Git-Tag: 2.3.9~1304 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=86d15f862c26e48fd1a63a0201dd3acc9135d094;p=thirdparty%2Fdovecot%2Fcore.git submission: commands: Expect connection setup errors from relaying commands. Subsequent changes remove the guarantee that the connection is setup successfuly (to gain EHLO capabilities) before commands are submitted. This means that the callbacks from commands can thereafter return connection setup errors as well. --- diff --git a/src/submission/submission-backend-relay.c b/src/submission/submission-backend-relay.c index f9e326f086..ace0519801 100644 --- a/src/submission/submission-backend-relay.c +++ b/src/submission/submission-backend-relay.c @@ -43,7 +43,8 @@ backend_relay_handle_relay_reply(struct submission_backend_relay *backend, case SMTP_CLIENT_COMMAND_ERROR_HOST_LOOKUP_FAILED: case SMTP_CLIENT_COMMAND_ERROR_CONNECT_FAILED: case SMTP_CLIENT_COMMAND_ERROR_AUTH_FAILED: - i_unreached(); + client_destroy(client, + "4.4.0", "Failed to connect to relay server"); return FALSE; case SMTP_CLIENT_COMMAND_ERROR_CONNECTION_CLOSED: case SMTP_CLIENT_COMMAND_ERROR_CONNECTION_LOST: