From: Jason Merrill <jason@redhat.com>
Date: Wed, 19 Oct 2011 22:29:15 +0000 (-0400)
Subject: re PR c++/50793 (G++ doesn't value-initialize all members of non-trivial type in... 
X-Git-Tag: releases/gcc-4.7.0~2965
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=875bcfdbf412ba625cf9ee9e1bd6610c0ad5b5f8;p=thirdparty%2Fgcc.git

re PR c++/50793 (G++ doesn't value-initialize all members of non-trivial type in default argument)

	PR c++/50793
	* tree.c (bot_manip): Propagate AGGR_INIT_ZERO_FIRST.

From-SVN: r180227
---

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 3b5c14c00778..8e9bb4a841df 100644
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,8 @@
+2011-10-19  Jason Merrill  <jason@redhat.com>
+
+	PR c++/50793
+	* tree.c (bot_manip): Propagate AGGR_INIT_ZERO_FIRST.
+
 2011-10-19  Roland Stigge  <stigge@antcom.de>
 
 	PR translation/49704
diff --git a/gcc/cp/tree.c b/gcc/cp/tree.c
index 75aa26503006..d023eb86cb8d 100644
--- a/gcc/cp/tree.c
+++ b/gcc/cp/tree.c
@@ -1879,8 +1879,12 @@ bot_manip (tree* tp, int* walk_subtrees, void* data)
       tree u;
 
       if (TREE_CODE (TREE_OPERAND (t, 1)) == AGGR_INIT_EXPR)
-	u = build_cplus_new (TREE_TYPE (t), TREE_OPERAND (t, 1),
-			     tf_warning_or_error);
+	{
+	  u = build_cplus_new (TREE_TYPE (t), TREE_OPERAND (t, 1),
+			       tf_warning_or_error);
+	  if (AGGR_INIT_ZERO_FIRST (TREE_OPERAND (t, 1)))
+	    AGGR_INIT_ZERO_FIRST (TREE_OPERAND (u, 1)) = true;
+	}
       else
 	u = build_target_expr_with_type (TREE_OPERAND (t, 1), TREE_TYPE (t),
 					 tf_warning_or_error);
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 12392074311c..173f195f2766 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2011-10-19  Jason Merrill  <jason@redhat.com>
+
+	PR c++/50793
+	* g++.dg/init/value9.C: New.
+
 2011-10-19  Jakub Jelinek  <jakub@redhat.com>
 
 	* gcc.dg/torture/vshuf-32.inc: Add interleave permutations.
diff --git a/gcc/testsuite/g++.dg/init/value9.C b/gcc/testsuite/g++.dg/init/value9.C
new file mode 100644
index 000000000000..4899bd81001a
--- /dev/null
+++ b/gcc/testsuite/g++.dg/init/value9.C
@@ -0,0 +1,32 @@
+// PR c++/50793
+// { dg-do run }
+
+struct NonTrivial
+{
+  NonTrivial() { }
+};
+
+struct S
+{
+  NonTrivial nt;
+  int i;
+};
+
+int f(S s)
+{
+  s.i = 0xdeadbeef;
+  return s.i;
+}
+
+int g(S s = S())
+{
+  return s.i;
+}
+
+int main()
+{
+  f(S());  // make stack dirty
+
+  if ( g() )
+    __builtin_abort();
+}