From: Colin Ian King Date: Tue, 23 Jul 2019 14:23:12 +0000 (+0100) Subject: drm/amd/display: fix a missing null check on a failed kzalloc X-Git-Tag: v5.4-rc1~106^2~17^2~215 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=87abff77880da827b8c9acb37e241999183b406f;p=thirdparty%2Flinux.git drm/amd/display: fix a missing null check on a failed kzalloc Currently the allocation of config may fail and a null pointer dereference on config can occur. Fix this by added a null check on a failed allocation of config. Addresses-Coverity: ("Dereference null return") Fixes: c2cd9d04ecf0 ("drm/amd/display: Hook up calls to do stereo mux and dig programming to stereo control interface") Signed-off-by: Colin Ian King Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index 94f126d2331c5..252b621d93a9c 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c @@ -1259,6 +1259,8 @@ bool dc_set_generic_gpio_for_stereo(bool enable, struct gpio_generic_mux_config *config = kzalloc(sizeof(struct gpio_generic_mux_config), GFP_KERNEL); + if (!config) + return false; pin_info = dal_gpio_get_generic_pin_info(gpio_service, GPIO_ID_GENERIC, 0); if (pin_info.mask == 0xFFFFFFFF || pin_info.offset == 0xFFFFFFFF) {