From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Thu, 1 May 2025 21:36:47 +0000 (-0400)
Subject: Add missing newlines to PQescapeInternal() messages pre-v16.
X-Git-Tag: REL_15_13~9
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=87af12e71fa9408e629f7a9772dc817de3ba44b8;p=thirdparty%2Fpostgresql.git

Add missing newlines to PQescapeInternal() messages pre-v16.

While back-patching 9f45e6a91, I neglected that the convention in
pre-v16 libpq was to include a trailing newline in error message
strings (since then, we add those separately).  Add them now.

Reported-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://postgr.es/m/a9c837ad-d507-4607-94e4-c5743a8f49e0@eisentraut.org
Backpatch-through: 13-15
---

diff --git a/src/interfaces/libpq/fe-exec.c b/src/interfaces/libpq/fe-exec.c
index 4a4731d048c..73c3a0f9025 100644
--- a/src/interfaces/libpq/fe-exec.c
+++ b/src/interfaces/libpq/fe-exec.c
@@ -4040,10 +4040,10 @@ PQescapeStringInternal(PGconn *conn,
 			{
 				if (remaining < charlen)
 					appendPQExpBufferStr(&conn->errorMessage,
-										 libpq_gettext("incomplete multibyte character"));
+										 libpq_gettext("incomplete multibyte character\n"));
 				else
 					appendPQExpBufferStr(&conn->errorMessage,
-										 libpq_gettext("invalid multibyte character"));
+										 libpq_gettext("invalid multibyte character\n"));
 				/* Issue a complaint only once per string */
 				already_complained = true;
 			}