From: Chaitra P B Date: Tue, 24 Apr 2018 09:28:42 +0000 (-0400) Subject: scsi: mpt3sas: fix possible memory leak. X-Git-Tag: v4.18-rc1~66^2~152 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=87b3576e9eaba85644c643bb55b485b5330a2af5;p=thirdparty%2Fkernel%2Flinux.git scsi: mpt3sas: fix possible memory leak. In ioctl exit path driver refers ioc_list to free memory associated with diag buffers and event_log pointer used to save events by driver. If ctl_exit() func is called after unregistering driver, then ioc_list will be empty and hence driver will not be able to free the allocated memory which in turn causes memory leak. So call ctl_exit() function before unregistering mpt3sas driver. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index 3dd70de581324..b8d131a455d01 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c @@ -11287,10 +11287,10 @@ _mpt3sas_exit(void) pr_info("mpt3sas version %s unloading\n", MPT3SAS_DRIVER_VERSION); - pci_unregister_driver(&mpt3sas_driver); - mpt3sas_ctl_exit(hbas_to_enumerate); + pci_unregister_driver(&mpt3sas_driver); + scsih_exit(); }