From: Jeff Layton <jlayton@kernel.org>
Date: Wed, 16 Nov 2022 13:50:52 +0000 (-0500)
Subject: ksmbd: use locks_inode_context helper
X-Git-Tag: v6.2-rc1~214^2~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=87f00aba211ef7308fd6c5d47d646a70bf196662;p=thirdparty%2Fkernel%2Flinux.git

ksmbd: use locks_inode_context helper

ksmbd currently doesn't access i_flctx safely. This requires a
smp_load_acquire, as the pointer is set via cmpxchg (a release
operation).

Cc: Steve French <sfrench@samba.org>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---

diff --git a/fs/ksmbd/vfs.c b/fs/ksmbd/vfs.c
index 8de970d6146f2..f9e85d6a160eb 100644
--- a/fs/ksmbd/vfs.c
+++ b/fs/ksmbd/vfs.c
@@ -321,7 +321,7 @@ static int check_lock_range(struct file *filp, loff_t start, loff_t end,
 			    unsigned char type)
 {
 	struct file_lock *flock;
-	struct file_lock_context *ctx = file_inode(filp)->i_flctx;
+	struct file_lock_context *ctx = locks_inode_context(file_inode(filp));
 	int error = 0;
 
 	if (!ctx || list_empty_careful(&ctx->flc_posix))