From: André Apitzsch <git@apitzsch.eu>
Date: Mon, 30 Jun 2025 19:05:25 +0000 (+0200)
Subject: media: i2c: imx214: Separate legacy link frequency check from PLL calculation
X-Git-Tag: v6.18-rc1~133^2~277
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=880c2395eb9c72938ae65bdb785d28426884d72f;p=thirdparty%2Fkernel%2Fstable.git

media: i2c: imx214: Separate legacy link frequency check from PLL calculation

Make it easier to drop the legacy support from the driver later.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: André Apitzsch <git@apitzsch.eu>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
---

diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
index cb630d0880109..94ebe625c9e6e 100644
--- a/drivers/media/i2c/imx214.c
+++ b/drivers/media/i2c/imx214.c
@@ -1362,18 +1362,16 @@ static int imx214_parse_fwnode(struct imx214 *imx214)
 		u64 freq = bus_cfg->link_frequencies[i];
 		struct ccs_pll pll;
 
-		if (!imx214_pll_calculate(imx214, &pll, freq))
-			break;
 		if (freq == IMX214_DEFAULT_LINK_FREQ_LEGACY) {
 			dev_warn(dev,
 				 "link-frequencies %d not supported, please review your DT. Continuing anyway\n",
 				 IMX214_DEFAULT_LINK_FREQ);
 			freq = IMX214_DEFAULT_LINK_FREQ;
-			if (imx214_pll_calculate(imx214, &pll, freq))
-				continue;
 			bus_cfg->link_frequencies[i] = freq;
-			break;
 		}
+
+		if (!imx214_pll_calculate(imx214, &pll, freq))
+			break;
 	}
 
 	if (i == bus_cfg->nr_of_link_frequencies)