From: Daniel P. Berrangé Date: Mon, 5 Feb 2024 15:40:19 +0000 (+0000) Subject: iotests: fix leak of tmpdir in dry-run mode X-Git-Tag: v8.2.2~68 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=88555e3607d322e46e1f33a2acf9a7f4055bfde9;p=thirdparty%2Fqemu.git iotests: fix leak of tmpdir in dry-run mode Creating an instance of the 'TestEnv' class will create a temporary directory. This dir is only deleted, however, in the __exit__ handler invoked by a context manager. In dry-run mode, we don't use the TestEnv via a context manager, so were leaking the temporary directory. Since meson invokes 'check' 5 times on each configure run, developers /tmp was filling up with empty temporary directories. Signed-off-by: Daniel P. Berrangé Message-ID: <20240205154019.1841037-1-berrange@redhat.com> Reviewed-by: Michael Tokarev Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf (cherry picked from commit c645bac4e06bf9642cc8e339d027a5d6ec54d811) Signed-off-by: Michael Tokarev --- diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check index f2e9d27dcf5..56d88ca4236 100755 --- a/tests/qemu-iotests/check +++ b/tests/qemu-iotests/check @@ -184,7 +184,8 @@ if __name__ == '__main__': sys.exit(str(e)) if args.dry_run: - print('\n'.join([os.path.basename(t) for t in tests])) + with env: + print('\n'.join([os.path.basename(t) for t in tests])) else: with TestRunner(env, tap=args.tap, color=args.color) as tr: