From: Joe Conway <mail@joeconway.com>
Date: Thu, 28 May 2020 17:16:47 +0000 (-0400)
Subject: Add CHECK_FOR_INTERRUPTS() to the repeat() function
X-Git-Tag: REL_13_BETA2~97
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=887cdff4dcbdfbfdbf9a29dfad0edc09c6ec3398;p=thirdparty%2Fpostgresql.git

Add CHECK_FOR_INTERRUPTS() to the repeat() function

The repeat() function loops for potentially a long time without
ever checking for interrupts. This prevents, for example, a query
cancel from interrupting until the work is all done. Fix by
inserting a CHECK_FOR_INTERRUPTS() into the loop.

Backpatch to all supported versions.

Discussion: https://www.postgresql.org/message-id/flat/8692553c-7fe8-17d9-cbc1-7cddb758f4c6%40joeconway.com
---

diff --git a/src/backend/utils/adt/oracle_compat.c b/src/backend/utils/adt/oracle_compat.c
index 0d56dc898ac..76e666474e8 100644
--- a/src/backend/utils/adt/oracle_compat.c
+++ b/src/backend/utils/adt/oracle_compat.c
@@ -17,6 +17,7 @@
 
 #include "common/int.h"
 #include "mb/pg_wchar.h"
+#include "miscadmin.h"
 #include "utils/builtins.h"
 #include "utils/formatting.h"
 
@@ -1061,6 +1062,7 @@ repeat(PG_FUNCTION_ARGS)
 	{
 		memcpy(cp, sp, slen);
 		cp += slen;
+		CHECK_FOR_INTERRUPTS();
 	}
 
 	PG_RETURN_TEXT_P(result);