From: Filipe Brandenburger <filbranden@google.com>
Date: Wed, 10 Aug 2016 20:17:12 +0000 (-0700)
Subject: tests: Use proper word splitting when executing tests
X-Git-Tag: v2.29-rc1~125
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=88a5f90e874cac53f5d24aed6542d4867be10e2d;p=thirdparty%2Futil-linux.git

tests: Use proper word splitting when executing tests

Use the shell special variable "$@" instead of the inferior $* to
execute the test command in ts_valgrind.  The expansion of "$@" respects
proper word splitting and makes it possible to pass the command empty
arguments.  It might also prevent surprises with quoting in corner
cases.

Tested that `make check` passes.

Valgrind run with `make check TS_OPTS='--nonroot --memcheck'` passes.

Signed-off-by: Filipe Brandenburger <filbranden@google.com>
---

diff --git a/tests/functions.sh b/tests/functions.sh
index b9a8523652..609cedffde 100644
--- a/tests/functions.sh
+++ b/tests/functions.sh
@@ -367,11 +367,11 @@ function ts_init_py {
 
 function ts_valgrind {
 	if [ -z "$TS_VALGRIND_CMD" ]; then
-		$*
+		"$@"
 	else
 		$TS_VALGRIND_CMD --tool=memcheck --leak-check=full \
 				 --leak-resolution=high --num-callers=20 \
-				 --log-file="$TS_VGDUMP" $*
+				 --log-file="$TS_VGDUMP" "$@"
 	fi
 }