From: Rusty Russell Date: Fri, 20 Mar 2015 03:48:12 +0000 (+1030) Subject: lguest: fix pending interrupt test. X-Git-Tag: v4.1-rc1~40^2~17 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=88ad1a147e2c84d33cb50f5ebff1ece5e0cd4383;p=thirdparty%2Flinux.git lguest: fix pending interrupt test. Denys says: TEST with zero will always set ZF. Thus, "jnz send_interrupts" never jumps. We get interrupts regularly enough that this didn't cause immediate problems. Reported-by: Denys Vlasenko Signed-off-by: Rusty Russell --- diff --git a/arch/x86/lguest/head_32.S b/arch/x86/lguest/head_32.S index 6ddfe4fc23c3e..05b0a85507ce8 100644 --- a/arch/x86/lguest/head_32.S +++ b/arch/x86/lguest/head_32.S @@ -84,7 +84,7 @@ ENTRY(lg_irq_enable) * set lguest_data.irq_pending to X86_EFLAGS_IF. If it's not zero, we * jump to send_interrupts, otherwise we're done. */ - testl $0, lguest_data+LGUEST_DATA_irq_pending + cmpl $0, lguest_data+LGUEST_DATA_irq_pending jnz send_interrupts /* * One cool thing about x86 is that you can do many things without using