From: Aaron Merey <amerey@redhat.com>
Date: Mon, 7 Nov 2022 16:26:32 +0000 (-0500)
Subject: debuginfod-client.c: Don't treat 0 as an error code.
X-Git-Tag: elfutils-0.189~61
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=88bab837c1d96a1f9a589dca74101ff378a0ff65;p=thirdparty%2Felfutils.git

debuginfod-client.c: Don't treat 0 as an error code.

Replace 'fd > 0' with 'fd >= 0' to avoid treating a possible file
descriptor as an error code.

Signed-off-by: Aaron Merey <amerey@redhat.com>
---

diff --git a/debuginfod/ChangeLog b/debuginfod/ChangeLog
index 5678002ab..a17bc5ab7 100644
--- a/debuginfod/ChangeLog
+++ b/debuginfod/ChangeLog
@@ -1,3 +1,8 @@
+2022-11-07  Aaron Merey  <amerey@redhat.com>
+
+	* debuginfod-client.c (debuginfod_find_section): Don't treat 0 as an
+	error code.
+
 2022-11-04  Aaron Merey  <amerey@redhat.com>
 
 	* debuginfod-client.c (debuginfod_find_section): Ensure rc
diff --git a/debuginfod/debuginfod-client.c b/debuginfod/debuginfod-client.c
index 99da05ef0..f9f26fd58 100644
--- a/debuginfod/debuginfod-client.c
+++ b/debuginfod/debuginfod-client.c
@@ -1936,7 +1936,7 @@ debuginfod_find_section (debuginfod_client *client,
 	}
       return -ENOENT;
     }
-  if (fd > 0)
+  if (fd >= 0)
     {
       rc = extract_section (fd, section, tmp_path, path);
       close (fd);
@@ -1948,7 +1948,7 @@ debuginfod_find_section (debuginfod_client *client,
 	 be in the executable.  */
       fd = debuginfod_find_executable (client, build_id,
 				       build_id_len, &tmp_path);
-      if (fd > 0)
+      if (fd >= 0)
 	{
 	  rc = extract_section (fd, section, tmp_path, path);
 	  close (fd);