From: Timo Sirainen <tss@iki.fi>
Date: Wed, 17 Jul 2013 07:23:21 +0000 (+0300)
Subject: liblib: connection_disconnect() didn't close fd_out if it was different from fd_in.
X-Git-Tag: 2.2.5~44
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=88df77efd9ffdfd9a62bca0a9c8f403ecdbea3ff;p=thirdparty%2Fdovecot%2Fcore.git

liblib: connection_disconnect() didn't close fd_out if it was different from fd_in.
---

diff --git a/src/lib/connection.c b/src/lib/connection.c
index a054219a82..88209ca1cd 100644
--- a/src/lib/connection.c
+++ b/src/lib/connection.c
@@ -254,7 +254,7 @@ void connection_disconnect(struct connection *conn)
 	if (conn->fd_in != -1) {
 		if (close(conn->fd_in) < 0)
 			i_error("close(%s) failed: %m", conn->name);
-		if (conn->fd_in != conn->fd_out)
+		if (conn->fd_in != conn->fd_out && close(conn->fd_out) < 0)
 			i_error("close(%s/out) failed: %m", conn->name);
 		conn->fd_in = conn->fd_out = -1;
 	}