From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Wed, 28 Aug 2019 10:05:52 +0000 (+0200)
Subject: shared/user-util: emit a warning on names with dots
X-Git-Tag: v243~23^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=88e2ed0b5bf6f08f5a2d4d64b1fefdc7192b9aac;p=thirdparty%2Fsystemd.git

shared/user-util: emit a warning on names with dots
---

diff --git a/src/basic/user-util.c b/src/basic/user-util.c
index b1ab84c5f05..3b253bc264d 100644
--- a/src/basic/user-util.c
+++ b/src/basic/user-util.c
@@ -645,13 +645,26 @@ bool valid_user_group_name_full(const char *u, bool strict) {
             u[0] != '_')
                 return false;
 
-        for (i = u+1; *i; i++)
-                if (!((*i >= 'a' && *i <= 'z') ||
-                      (*i >= 'A' && *i <= 'Z') ||
-                      (*i >= '0' && *i <= '9') ||
-                      IN_SET(*i, '_', '-') ||
-                      (!strict && *i == '.')))
-                        return false;
+        bool warned = false;
+
+        for (i = u+1; *i; i++) {
+                if (((*i >= 'a' && *i <= 'z') ||
+                     (*i >= 'A' && *i <= 'Z') ||
+                     (*i >= '0' && *i <= '9') ||
+                     IN_SET(*i, '_', '-')))
+                        continue;
+
+                if (*i == '.' && !strict) {
+                        if (!warned) {
+                                log_warning("Bad user or group name \"%s\", accepting for compatibility.", u);
+                                warned = true;
+                        }
+
+                        continue;
+                }
+
+                return false;
+        }
 
         sz = sysconf(_SC_LOGIN_NAME_MAX);
         assert_se(sz > 0);