From: Daniel Stenberg <daniel@haxx.se>
Date: Tue, 8 Oct 2024 10:42:05 +0000 (+0200)
Subject: setopt: avoid superfluous length checks before strcmp()
X-Git-Tag: curl-8_11_0~206
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=88ef62ba22c2590df81d7f16bc2db075376dd9fc;p=thirdparty%2Fcurl.git

setopt: avoid superfluous length checks before strcmp()

Simplify the checks

Closes #15192
---

diff --git a/lib/setopt.c b/lib/setopt.c
index 305555789b..396caaeb1a 100644
--- a/lib/setopt.c
+++ b/lib/setopt.c
@@ -3165,16 +3165,16 @@ CURLcode Curl_vsetopt(struct Curl_easy *data, CURLoption option, va_list param)
       return CURLE_BAD_FUNCTION_ARGUMENT;
     }
     /* set tls_ech flag value, preserving CLA_CFG bit */
-    if(plen == 5 && !strcmp(argptr, "false"))
+    if(!strcmp(argptr, "false"))
       data->set.tls_ech = CURLECH_DISABLE |
         (data->set.tls_ech & CURLECH_CLA_CFG);
-    else if(plen == 6 && !strcmp(argptr, "grease"))
+    else if(!strcmp(argptr, "grease"))
       data->set.tls_ech = CURLECH_GREASE |
         (data->set.tls_ech & CURLECH_CLA_CFG);
-    else if(plen == 4 && !strcmp(argptr, "true"))
+    else if(!strcmp(argptr, "true"))
       data->set.tls_ech = CURLECH_ENABLE |
         (data->set.tls_ech & CURLECH_CLA_CFG);
-    else if(plen == 4 && !strcmp(argptr, "hard"))
+    else if(!strcmp(argptr, "hard"))
       data->set.tls_ech = CURLECH_HARD |
         (data->set.tls_ech & CURLECH_CLA_CFG);
     else if(plen > 5 && !strncmp(argptr, "ecl:", 4)) {