From: Daniel P. Berrangé <berrange@redhat.com>
Date: Mon, 28 Apr 2025 10:43:30 +0000 (+0100)
Subject: tests: storage hardcoding paths for mount & vgchange
X-Git-Tag: v11.4.0-rc1~134
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=88f560b6191ecb22c77032ca523fb100e7e23ec9;p=thirdparty%2Flibvirt.git

tests: storage hardcoding paths for mount & vgchange

This is redundant since the tests will strip any path component from the
binary name before comparison.

Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/tests/storagepoolxml2argvtest.c b/tests/storagepoolxml2argvtest.c
index e8e40d695e..d5c2531ab8 100644
--- a/tests/storagepoolxml2argvtest.c
+++ b/tests/storagepoolxml2argvtest.c
@@ -6,14 +6,6 @@
 
 #define VIR_FROM_THIS VIR_FROM_NONE
 
-#ifndef MOUNT
-# define MOUNT "/usr/bin/mount"
-#endif
-
-#ifndef VGCHANGE
-# define VGCHANGE "/usr/sbin/vgchange"
-#endif
-
 static int
 testCompareXMLToArgvFiles(bool shouldFail,
                           const char *poolxml,
@@ -46,12 +38,12 @@ testCompareXMLToArgvFiles(bool shouldFail,
             goto cleanup;
         }
 
-        cmd = virStorageBackendFileSystemMountCmd(MOUNT, def, src);
+        cmd = virStorageBackendFileSystemMountCmd("mount", def, src);
         def = NULL;
         break;
 
     case VIR_STORAGE_POOL_LOGICAL:
-        cmd = virStorageBackendLogicalChangeCmd(VGCHANGE, def, true);
+        cmd = virStorageBackendLogicalChangeCmd("vgchange", def, true);
         break;
 
     case VIR_STORAGE_POOL_DIR: