From: Daniel Stenberg <daniel@haxx.se>
Date: Tue, 21 Nov 2023 07:13:08 +0000 (+0100)
Subject: transfer: avoid unreachable expression
X-Git-Tag: curl-8_5_0~66
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=891f1041d61ad86bbdc2e9b3423b04ec856a8058;p=thirdparty%2Fcurl.git

transfer: avoid unreachable expression

If curl_off_t and size_t have the same size (which is common on modern
64 bit systems), a condition cannot occur which Coverity pointed
out. Avoid the warning by having the code conditionally only used if
curl_off_t actually is larger.

Follow-up to 1cd2f0072fa482e25baa2

Closes #12370
---

diff --git a/lib/transfer.c b/lib/transfer.c
index a4aae12825..fa7f97ec69 100644
--- a/lib/transfer.c
+++ b/lib/transfer.c
@@ -423,9 +423,11 @@ static size_t get_max_body_write_len(struct Curl_easy *data)
       /* already written too much! */
       return 0;
     }
+#if SIZEOF_CURL_OFF_T > SIZEOF_SIZE_T
     else if(remain_diff > SSIZE_T_MAX) {
       return SIZE_T_MAX;
     }
+#endif
     else {
       return (size_t)remain_diff;
     }