From: Johannes Berg Date: Wed, 29 Mar 2023 07:05:25 +0000 (+0300) Subject: wifi: iwlwifi: mvm: avoid sending MAC context for idle X-Git-Tag: v6.4-rc1~132^2~151^2~16 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8930ed56734d2975f954e0447e65472c142aa88b;p=thirdparty%2Fkernel%2Flinux.git wifi: iwlwifi: mvm: avoid sending MAC context for idle If we change only idle, avoid sending the MAC context command since it doesn't depend on idle state. This also fixes an issue with the firmware because without this we send the command during link switching, as we just deactivated the first link, and we cannot send this command when there's no active link. Signed-off-by: Johannes Berg Signed-off-by: Gregory Greenman Link: https://lore.kernel.org/r/20230329100039.f5218f8453ec.I1325ff14ec07a27dd7ea2c1c210a1721d969839f@changeid Signed-off-by: Johannes Berg --- diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c index 1a97bf9258173..8ed76fc837027 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c @@ -563,6 +563,12 @@ static void iwl_mvm_mld_vif_cfg_changed_station(struct iwl_mvm *mvm, unsigned int i; int ret; + /* This might get called without active links during the + * chanctx switch, but we don't care about it anyway. + */ + if (changes == BSS_CHANGED_IDLE) + return; + ret = iwl_mvm_mld_mac_ctxt_changed(mvm, vif, false); if (ret) IWL_ERR(mvm, "failed to update MAC %pM\n", vif->addr);