From: Marc Zyngier Date: Sat, 15 Dec 2018 09:10:46 +0000 (+0000) Subject: irqchip/irq-imx-gpcv2: Silence "fall through" warning X-Git-Tag: v5.0-rc1~169^2~3^2~7 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=893b0aff9a7aa68d2fcc999f16d66d142f180ca8;p=thirdparty%2Fkernel%2Flinux.git irqchip/irq-imx-gpcv2: Silence "fall through" warning The -Wimplicit-fallthrough option requires that the /* fall through */ comment is placed in the 'case' statement that falls through, rather than in the following one. Case seems to matter as well. Reported-by: Stephen Rothwell Signed-off-by: Marc Zyngier --- diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c index 17a2dad2d4c2f..d13269c9effc3 100644 --- a/drivers/irqchip/irq-imx-gpcv2.c +++ b/drivers/irqchip/irq-imx-gpcv2.c @@ -261,7 +261,8 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node, case 4: writel_relaxed(~0, reg + GPC_IMR1_CORE2); writel_relaxed(~0, reg + GPC_IMR1_CORE3); - case 2: /* FALLTHROUGH */ + /* fall through */ + case 2: writel_relaxed(~0, reg + GPC_IMR1_CORE0); writel_relaxed(~0, reg + GPC_IMR1_CORE1); }