From: Greg Kroah-Hartman Date: Wed, 21 Feb 2024 12:30:20 +0000 (+0100) Subject: 5.10-stable patches X-Git-Tag: v4.19.307~12 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=893c5eaefd936831e0bf0b1b5f9e9ccc6497ceab;p=thirdparty%2Fkernel%2Fstable-queue.git 5.10-stable patches added patches: pci-dwc-fix-a-64bit-bug-in-dw_pcie_ep_raise_msix_irq.patch --- diff --git a/queue-5.10/pci-dwc-fix-a-64bit-bug-in-dw_pcie_ep_raise_msix_irq.patch b/queue-5.10/pci-dwc-fix-a-64bit-bug-in-dw_pcie_ep_raise_msix_irq.patch new file mode 100644 index 00000000000..f7ffb926ae0 --- /dev/null +++ b/queue-5.10/pci-dwc-fix-a-64bit-bug-in-dw_pcie_ep_raise_msix_irq.patch @@ -0,0 +1,52 @@ +From b5d1b4b46f856da1473c7ba9a5cdfcb55c9b2478 Mon Sep 17 00:00:00 2001 +From: Dan Carpenter +Date: Fri, 26 Jan 2024 11:40:37 +0300 +Subject: PCI: dwc: Fix a 64bit bug in dw_pcie_ep_raise_msix_irq() +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Dan Carpenter + +commit b5d1b4b46f856da1473c7ba9a5cdfcb55c9b2478 upstream. + +The "msg_addr" variable is u64. However, the "aligned_offset" is an +unsigned int. This means that when the code does: + + msg_addr &= ~aligned_offset; + +it will unintentionally zero out the high 32 bits. Use ALIGN_DOWN() to do +the alignment instead. + +Fixes: 2217fffcd63f ("PCI: dwc: endpoint: Fix dw_pcie_ep_raise_msix_irq() alignment support") +Link: https://lore.kernel.org/r/af59c7ad-ab93-40f7-ad4a-7ac0b14d37f5@moroto.mountain +Signed-off-by: Dan Carpenter +Signed-off-by: Bjorn Helgaas +Reviewed-by: Niklas Cassel +Reviewed-by: Ilpo Järvinen +Reviewed-by: Manivannan Sadhasivam +Cc: +Signed-off-by: Greg Kroah-Hartman +--- + drivers/pci/controller/dwc/pcie-designware-ep.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +--- a/drivers/pci/controller/dwc/pcie-designware-ep.c ++++ b/drivers/pci/controller/dwc/pcie-designware-ep.c +@@ -6,6 +6,7 @@ + * Author: Kishon Vijay Abraham I + */ + ++#include + #include + + #include "pcie-designware.h" +@@ -593,7 +594,7 @@ int dw_pcie_ep_raise_msix_irq(struct dw_ + } + + aligned_offset = msg_addr & (epc->mem->window.page_size - 1); +- msg_addr &= ~aligned_offset; ++ msg_addr = ALIGN_DOWN(msg_addr, epc->mem->window.page_size); + ret = dw_pcie_ep_map_addr(epc, func_no, ep->msi_mem_phys, msg_addr, + epc->mem->window.page_size); + if (ret) diff --git a/queue-5.10/series b/queue-5.10/series index 7931558976f..0490d9e779f 100644 --- a/queue-5.10/series +++ b/queue-5.10/series @@ -377,3 +377,4 @@ pm-runtime-have-devm_pm_runtime_enable-handle-pm_runtime_dont_use_autosuspend.pa drm-msm-dsi-enable-runtime-pm.patch netfilter-nf_tables-fix-pointer-math-issue-in-nft_byteorder_eval.patch net-bcmgenet-fix-eee-implementation.patch +pci-dwc-fix-a-64bit-bug-in-dw_pcie_ep_raise_msix_irq.patch