From: Daniel Stenberg <daniel@haxx.se>
Date: Wed, 12 Sep 2001 07:19:11 +0000 (+0000)
Subject: *TERRIBLE* terrible memory leak occuring on all systems that have no
X-Git-Tag: curl-7_9~49
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8950a2dfa1c9f4dda56624a0813c860df561b97e;p=thirdparty%2Fcurl.git

*TERRIBLE* terrible memory leak occuring on all systems that have no
gethostbyname_r() function, most notably windows machines...
---

diff --git a/lib/hostip.c b/lib/hostip.c
index 8526fb91ca..be365d45f2 100644
--- a/lib/hostip.c
+++ b/lib/hostip.c
@@ -125,6 +125,8 @@ struct hostent *Curl_gethost(struct SessionHandle *data,
 {
   struct hostent *h = NULL;
   unsigned long in;
+
+#ifdef HAVE_GETHOSTBYNAME_R
   int ret; /* this variable is unused on several platforms but used on some */
 
 #define CURL_NAMELOOKUP_SIZE 9000
@@ -136,7 +138,7 @@ struct hostent *Curl_gethost(struct SessionHandle *data,
   if(!buf)
     return NULL; /* major failure */
   *bufp = buf;
-
+#endif
   ret = 0; /* to prevent the compiler warning */
 
   if ( (in=inet_addr(hostname)) != INADDR_NONE ) {
@@ -206,10 +208,9 @@ struct hostent *Curl_gethost(struct SessionHandle *data,
     }
 #else
   else {
+    *bufp=NULL; /* zero this always */
     if ((h = gethostbyname(hostname)) == NULL ) {
       infof(data, "gethostbyname(2) failed for %s\n", hostname);
-      free(buf);
-      *bufp=NULL;
     }
 #endif
   }