From: Jean Lecordier <47030586+jlecordier@users.noreply.github.com>
Date: Thu, 24 Feb 2022 23:10:38 +0000 (+0100)
Subject: Remove useless if in js example
X-Git-Tag: 0.9.4~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=895b77b3a9c2cfd199b97d2cd602213ee76dac2e;p=thirdparty%2Fbulma.git

Remove useless if in js example

If the length is 0, then the forEach call does nothing anyway

Could we remove the slice part as well ? If IE support is required, can’t we just use Array.prototype.forEach ? Can’t we just remove IE support all together to promote clean and up to date code ? Polyfills and code transpilation are here to help support IE
---

diff --git a/docs/documentation/components/navbar.html b/docs/documentation/components/navbar.html
index efae333bb..f2e649413 100644
--- a/docs/documentation/components/navbar.html
+++ b/docs/documentation/components/navbar.html
@@ -565,24 +565,20 @@ document.addEventListener('DOMContentLoaded', () => {
   // Get all "navbar-burger" elements
   const $navbarBurgers = Array.prototype.slice.call(document.querySelectorAll('.navbar-burger'), 0);
 
-  // Check if there are any navbar burgers
-  if ($navbarBurgers.length > 0) {
+  // Add a click event on each of them
+  $navbarBurgers.forEach( el => {
+    el.addEventListener('click', () => {
 
-    // Add a click event on each of them
-    $navbarBurgers.forEach( el => {
-      el.addEventListener('click', () => {
+      // Get the target from the "data-target" attribute
+      const target = el.dataset.target;
+      const $target = document.getElementById(target);
 
-        // Get the target from the "data-target" attribute
-        const target = el.dataset.target;
-        const $target = document.getElementById(target);
-
-        // Toggle the "is-active" class on both the "navbar-burger" and the "navbar-menu"
-        el.classList.toggle('is-active');
-        $target.classList.toggle('is-active');
+      // Toggle the "is-active" class on both the "navbar-burger" and the "navbar-menu"
+      el.classList.toggle('is-active');
+      $target.classList.toggle('is-active');
 
-      });
     });
-  }
+  });
 
 });
 {% endcapture %}