From: Brian Norris Date: Mon, 14 Oct 2019 21:26:48 +0000 (-0700) Subject: rtw88: mark rtw_fw_hdr __packed X-Git-Tag: v5.5-rc1~174^2~213^2~27 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=89dca86d29b46f2a5f38ea6476cfd441bd205d25;p=thirdparty%2Fkernel%2Flinux.git rtw88: mark rtw_fw_hdr __packed The use of u8 and __le16 in this struct assumes that it's going to be packed to byte alignment. C doesn't guarantee that, so we should mark this __packed. Fixes: cc20a7139836 ("rtw88: use struct rtw_fw_hdr to access firmware header") Cc: Ping-Ke Shih Signed-off-by: Brian Norris Signed-off-by: Kalle Valo --- diff --git a/drivers/net/wireless/realtek/rtw88/fw.h b/drivers/net/wireless/realtek/rtw88/fw.h index 4f79993942359..73d1b9ca8efcd 100644 --- a/drivers/net/wireless/realtek/rtw88/fw.h +++ b/drivers/net/wireless/realtek/rtw88/fw.h @@ -127,7 +127,7 @@ struct rtw_fw_hdr { __le32 emem_size; __le32 emem_addr; __le32 imem_addr; -}; +} __packed; /* C2H */ #define GET_CCX_REPORT_SEQNUM(c2h_payload) (c2h_payload[8] & 0xfc)