From: Christopher Faulet <cfaulet@haproxy.com>
Date: Wed, 1 Jun 2022 15:17:24 +0000 (+0200)
Subject: MEDIUM: httpclient: Don't close CLI applet at the end of a response
X-Git-Tag: v2.7-dev1~120
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=89f2626c19eac0c27f539039fd950b5b8f2ec7ee;p=thirdparty%2Fhaproxy.git

MEDIUM: httpclient: Don't close CLI applet at the end of a response

There is no reason to close the CLI applet when the whole response was
dumped. This prevent anyone to use the CLI in interactive mode.
---

diff --git a/src/http_client.c b/src/http_client.c
index 677161beb5..a195832431 100644
--- a/src/http_client.c
+++ b/src/http_client.c
@@ -235,15 +235,16 @@ static int hc_cli_io_handler(struct appctx *appctx)
 
 	/* we must close only if F_END is the last flag */
 	if (ctx->flags ==  HC_CLI_F_RES_END) {
-		sc_shutw(sc);
-		sc_shutr(sc);
 		ctx->flags &= ~HC_CLI_F_RES_END;
+		goto end;
 	}
 
 more:
 	if (!ctx->flags)
 		applet_have_no_more_data(appctx);
 	return 0;
+end:
+	return 1;
 
 too_many_hdrs:
 	return cli_err(appctx, "Too many headers.\n");