From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Tue, 21 Nov 2023 07:27:45 +0000 (+0100)
Subject: dnsdist: Fix a 'auto causes a copy' warning from Coverity (CID 408612)
X-Git-Tag: rec-5.0.0-rc1~3^2~6
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=89f3e9ace268e3e91fc90717b5d52699c6a9c86a;p=thirdparty%2Fpdns.git

dnsdist: Fix a 'auto causes a copy' warning from Coverity (CID 408612)
---

diff --git a/pdns/dnsdist-lua.cc b/pdns/dnsdist-lua.cc
index 157076025c..958875c743 100644
--- a/pdns/dnsdist-lua.cc
+++ b/pdns/dnsdist-lua.cc
@@ -1571,7 +1571,7 @@ static void setupLuaConfig(LuaContext& luaCtx, bool client, bool configCheck)
                            clientIPCA = boost::get<ComboAddress>(clientIP);
                          }
                          else {
-                           auto clientIPStr = boost::get<std::string>(clientIP);
+                           const auto& clientIPStr = boost::get<std::string>(clientIP);
                            try {
                              clientIPCA = ComboAddress(clientIPStr);
                            }