From: Stanislaw Gruszka Date: Mon, 6 May 2019 07:39:17 +0000 (+0200) Subject: rtw88: fix subscript above array bounds compiler warning X-Git-Tag: v5.2-rc6~33^2~45^2~14 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8a03447dd311da2ad2df74dcf730a1a15f673379;p=thirdparty%2Fkernel%2Flinux.git rtw88: fix subscript above array bounds compiler warning My compiler complains about: drivers/net/wireless/realtek/rtw88/phy.c: In function ‘rtw_phy_rf_power_2_rssi’: drivers/net/wireless/realtek/rtw88/phy.c:430:26: warning: array subscript is above array bounds [-Warray-bounds] linear = db_invert_table[i][j]; According to comment power_db should be in range 1 ~ 96 . To fix add check for boundaries before access the array. Signed-off-by: Stanislaw Gruszka Acked-by: Yan-Hsuan Chuang Signed-off-by: Kalle Valo --- diff --git a/drivers/net/wireless/realtek/rtw88/phy.c b/drivers/net/wireless/realtek/rtw88/phy.c index 4381b360b5b53..8284a77973987 100644 --- a/drivers/net/wireless/realtek/rtw88/phy.c +++ b/drivers/net/wireless/realtek/rtw88/phy.c @@ -423,6 +423,11 @@ static u64 rtw_phy_db_2_linear(u8 power_db) u8 i, j; u64 linear; + if (power_db > 96) + power_db = 96; + else if (power_db < 1) + return 1; + /* 1dB ~ 96dB */ i = (power_db - 1) >> 3; j = (power_db - 1) - (i << 3);