From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Mon, 9 Jun 2025 08:20:13 +0000 (+0300)
Subject: dict: Remove unnecessary parsing of value_type parameter in handshake
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=8a050e46536b5c498981ef2ec4ce23178475f7ca;p=thirdparty%2Fdovecot%2Fcore.git

dict: Remove unnecessary parsing of value_type parameter in handshake

It's not actually used for anything
---

diff --git a/src/dict/dict-connection.c b/src/dict/dict-connection.c
index 45438283dd..2cf80af857 100644
--- a/src/dict/dict-connection.c
+++ b/src/dict/dict-connection.c
@@ -26,11 +26,12 @@ struct connection_list *dict_connections = NULL;
 static int dict_connection_handshake_args(struct connection *_conn,
 					  const char *const *args)
 {
-	unsigned int major, value_type_num;
+	unsigned int major;
 	struct dict_connection *conn =
 		container_of(_conn, struct dict_connection, conn);
 
-	/* protocol handshake is 'H' major <tab> minor <tab> value_type */
+	/* protocol handshake is:
+	   'H' major <tab> minor <tab> 0 <tab> <tab> dict_name */
 	if (str_array_length(args) < 5 || **args != 'H')
 		return -1;
 
@@ -41,12 +42,6 @@ static int dict_connection_handshake_args(struct connection *_conn,
 	    major != DICT_CLIENT_PROTOCOL_MAJOR_VERSION)
 		return -1;
 
-	/* check value type */
-	if (str_to_uint(args[2], &value_type_num) < 0 ||
-	    value_type_num >= DICT_DATA_TYPE_LAST)
-		return -1;
-
-	conn->value_type = (enum dict_data_type)value_type_num;
 	conn->name = i_strdup(args[4]);
 
 	/* try initialize the given dict */
diff --git a/src/dict/dict-connection.h b/src/dict/dict-connection.h
index 2241dade79..d8f278fe7a 100644
--- a/src/dict/dict-connection.h
+++ b/src/dict/dict-connection.h
@@ -18,7 +18,6 @@ struct dict_connection {
 
 	char *name;
 	struct dict *dict;
-	enum dict_data_type value_type;
 
 	struct timeout *to_unref;